Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include prefer wait in watch request even after initial 404 read request #1295

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

jfallows
Copy link
Contributor

Description

Before this change, if the initial request for zilla.yaml receives 404 not found, then the next watch request would not include prefer: wait=N so it can return immediately with 404 also, causing the next watch request to be sent only after a poll interval, which is 60s by default.

After this change, even if the initial request for zilla.yaml receives 404, then the next watch request now includes prefer: wait=N and responds immediately when the response becomes available, with no need for polling.

@jfallows jfallows requested a review from akrambek October 12, 2024 19:34
@jfallows jfallows enabled auto-merge (squash) October 12, 2024 19:34
@jfallows jfallows merged commit cb44f1e into aklivity:develop Oct 12, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants