enabling error reporting using supplyReporter
#1348
Conversation
| final Consumer<Throwable> report = exceptions | ||
| final Consumer<Throwable> reporter = exceptions | ||
| ? e -> e.printStackTrace(System.err) | ||
| : e -> System.err.println(e.getMessage()); | ||
|
|
||
| final ErrorHandler onError = ex -> | ||
| { | ||
| report.accept(ex); | ||
| reporter.accept(ex); | ||
| stop.countDown(); | ||
| }; |
There was a problem hiding this comment.
There is still code duplication between zilla start here and the default reporter in EngineBuilder.
If we omit the reporter then it will default.
Perhaps it should default to reporting the exception and then triggering the error handler by default when onError would otherwise be called, so that we are not forced to explicitly create the reported here just to chain with the error handler.
We should also move the defaulting logic to EngineConfiguration. For that to work, we'll need to create an inner functional interface in EngineConfiguration, something like ErrorReporter which has void report(Throwable ex) or similar and default method that returns a different value depending on exceptions configuraiton setting in EngineConfiguration.
Note that the property type might need to be a Supplier<Consumer<Throwable>> instead of just Consumer<Throwable> so that it can return a distinct instance per EngineWorker.
| Consumer<Throwable> supplyReporter(); | ||
|
|
There was a problem hiding this comment.
| Consumer<Throwable> supplyReporter(); | |
| void report( | |
| Throwable ex); | |
Perhaps this is sufficient, since the reporter would be created once per EngineWorker and reused for the same core anyway.
| @@ -119,6 +124,10 @@ else if (keyTypes != null) | |||
| } | |||
| } | |||
| } | |||
| if (debug) | |||
| { | |||
| System.out.printf("No match found for Subject CN and Key Types"); | |||
There was a problem hiding this comment.
We need the actual CN, key types and issuers here please.
| { | ||
| props.setProperty(ENGINE_VERBOSE.name(), Boolean.toString(verbose)); | ||
| } | ||
| props.setProperty(ENGINE_VERBOSE.name(), Boolean.toString(verbose)); |
There was a problem hiding this comment.
This is a change of behavior, because it will explicitly override verbose to false if not specified instead of picking up the value from zilla.properties or the -P value.
Please restore the if check and add a similar check for exceptions too.
No description provided.