Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gRPC client stream/unary oneway #1384

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Support gRPC client stream/unary oneway #1384

merged 6 commits into from
Feb 4, 2025

Conversation

ankitk-me
Copy link
Contributor

Fixes #642

@ankitk-me ankitk-me marked this pull request as draft January 28, 2025 07:37
@ankitk-me ankitk-me requested a review from jfallows January 28, 2025 07:38
@ankitk-me ankitk-me marked this pull request as ready for review January 29, 2025 11:32
jfallows
jfallows reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we implicitly sending the empty message in the grpc reply to the client?
Naturally that is not coming from Kafka because we are doing produce only oneway.

@jfallows jfallows merged commit cf16ddb into aklivity:develop Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support gRPC client streaming to Kafka directly
2 participants
@ankitk-me @jfallows