Include data payload as hex in the output of log command #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
force-pushed
the
command-log-payload
branch
from
1929935 to
3f02596
Compare
jfallows
requested changes
Nov 2, 2023
...tor/command-log/src/main/java/io/aklivity/zilla/runtime/command/log/internal/LogCommand.java
Outdated
Show resolved
Hide resolved
...mand-log/src/main/java/io/aklivity/zilla/runtime/command/log/internal/LogStreamsCommand.java
Outdated
Show resolved
Hide resolved
...mand-log/src/main/java/io/aklivity/zilla/runtime/command/log/internal/LogStreamsCommand.java
Outdated
Show resolved
Hide resolved
...command-log/src/main/java/io/aklivity/zilla/runtime/command/log/internal/LoggableStream.java
Outdated
Show resolved
Hide resolved
...command-log/src/main/java/io/aklivity/zilla/runtime/command/log/internal/LoggableStream.java
Outdated
Show resolved
Hide resolved
...command-log/src/main/java/io/aklivity/zilla/runtime/command/log/internal/LoggableStream.java
Outdated
Show resolved
Hide resolved
...command-log/src/main/java/io/aklivity/zilla/runtime/command/log/internal/LoggableStream.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Nov 7, 2023
| hexData.append(String.format("%02x", payload.buffer().getByte(payload.offset() + i))); | ||
| hexData.append(i < data.length() - 1 ? ':' : ""); | ||
| } | ||
| out.printf(verboseFormat, index, offset, timestamp, hexData); |
There was a problem hiding this comment.
Please take a look at using BitUtil.toHex(...) with a shared temporary byte array instead of string builder append.
There was a problem hiding this comment.
Use payload.buffer.getBytes(...) to populate the byte[].
jfallows
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a command line switch
-por--payloadto include the payload of theDATAframes as a hex string in the output of thelogcommand.Fixes # (issue)