Implement mqtt message expiry #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Dec 13, 2023
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Show resolved
Hide resolved
...io/aklivity/zilla/specs/binding/mqtt/kafka/streams/kafka/subscribe.expire.message/client.rpt
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/specs/binding/mqtt/kafka/streams/kafka/subscribe.expire.message/server.rpt
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Dec 19, 2023
...lla/specs/binding/mqtt/kafka/streams/kafka/publish.one.message.changed.topic.name/client.rpt
Outdated
Show resolved
Hide resolved
.../zilla/specs/binding/mqtt/kafka/streams/kafka/subscribe.expire.message.fragmented/client.rpt
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeProxyIT.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeProxyIT.java
Outdated
Show resolved
Hide resolved
| @@ -1455,6 +1461,7 @@ private void onKafkaData( | |||
| expireInterval = timestamp + helper.timeout - now().toEpochMilli(); | |||
| if (expireInterval < 0) | |||
| { | |||
| expiredMessage = true; | |||
There was a problem hiding this comment.
long expireInterval;
if (helper.timeout != -1)
{
...
}
else
{
expireInterval = helper.timeout;
}
can this be simplified to:
long expireInterval = -1;
if (helper.timeout != -1)
{
...
}
There was a problem hiding this comment.
Originally I wanted to write this like you showed. But as we're using the expireInterval in a lambda we'd get:
"Variable used in lambda expression should be final or effectively final".
jfallows
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.