Support MQTT fragmented messages #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jan 5, 2024
There was a problem hiding this comment.
Btw, although we have removed maximum packet size as a limitation, it may still be relevant to reject messages that are too large, for example when Kafka rejects the message as exceeding maximum message size.
So we probably need to detect this case, and make sure the MQTT client understands that the publish is failing because the message is too large, by receiving a suitable error code at the MQTT client.
What happens when the message in Kafka is larger than the maximum packet size would permit to send the MQTT client?
...main/scripts/io/aklivity/zilla/specs/binding/mqtt/streams/application/publish.10k/server.rpt
Show resolved
Hide resolved
...ipts/io/aklivity/zilla/specs/binding/mqtt/kafka/streams/mqtt/publish.retained.10k/server.rpt
Show resolved
Hide resolved
.../main/scripts/io/aklivity/zilla/specs/binding/mqtt/kafka/streams/mqtt/publish.10k/server.rpt
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttClientFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttClientFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jan 8, 2024
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttClientFactory.java
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
...test/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/server/v5/ConnectionIT.java
Outdated
Show resolved
Hide resolved
...klivity/zilla/specs/binding/mqtt/kafka/streams/kafka/publish.reject.large.message/server.rpt
Show resolved
Hide resolved
jfallows
requested changes
Jan 9, 2024
jfallows
previously approved these changes
Jan 9, 2024
jfallows
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #282