Model specific cache detect schema change update #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jan 30, 2024
| private int generateCRC32C( | ||
| String schemaText) | ||
| { | ||
| byte[] bytes = schemaText.getBytes(); |
There was a problem hiding this comment.
This line is going to allocate a new byte[] on every call to validate.
Let's instead store the actual schemaText rather than a crc32c hash to compare.
| private int generateCRC32C( | ||
| String schemaText) | ||
| { | ||
| byte[] bytes = schemaText.getBytes(); |
There was a problem hiding this comment.
Same feedback here as for avro.
| private int generateCRC32C( | ||
| String schemaText) | ||
| { | ||
| byte[] bytes = schemaText.getBytes(); |
There was a problem hiding this comment.
Same feedback here as for avro.
jfallows
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.