Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement filesystem catalog #962

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Implement filesystem catalog #962

merged 8 commits into from
Apr 19, 2024

Conversation

bmaidics
Copy link
Contributor

No description provided.

@bmaidics
Copy link
Contributor Author

@jfallows , please check the last commit: 28696c7
First I took another approach to get reference for the readURL in the namespace config and I can't decide for sure which one is better. Get it from the adaptContext, or directly set it for every catalog? I have a feeling adaptContext will be the winner though.

@bmaidics bmaidics linked an issue Apr 17, 2024 that may be closed by this pull request
Support filesystem catalog for local schemas #908
Closed
@bmaidics bmaidics mentioned this pull request Apr 18, 2024
Merged
jfallows
jfallows requested changes Apr 19, 2024
View reviewed changes
@jfallows jfallows merged commit 4a5f85d into aklivity:develop Apr 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support filesystem catalog for local schemas
2 participants
@bmaidics @jfallows