Fix CONRAD.getClasses when running with pyconrad #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you check whether the StandAlone Version still works after this change? Do we need a new Conrad release then? |
|
I only tested it with the compiled Java code. With and without pyconrad. Since the patch only does things if Finding all filter classes when launched by pyconrad would require this patch and a new CONRAD release. |
On pyconrad, the thread that runs CONRAD GUI gets detached from JVM. Therefore, `Thread.currentThread().getContextClassLoader()` returns `null`. We can solve this problem by patching a private member from pyconrad.
theHamsta
force-pushed
the
fix-getContextClassLoader-on-pyconrad
branch
from
8674665
to
1ca58eb
Compare
|
JAR can be tested by pip install pyconrad --upgrade
export CONRAD_DEV_DIRS=/folder/of/fixed/jar/file/
conradExpected result: Loading CONRAD filters in CONRAD GUI only works if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On pyconrad, the thread that runs CONRAD GUI is not the first thread on the JVM.
Therefore or for some other reason,
Thread.currentThread().getContextClassLoader()returnsnull.We can solve this problem by patching a private member from pyconrad.
Any better ideas? Setting the setContextClassLoader on the pyconrad side did not work. Patching the whole getClasses method with pyconrad was to drastic for me.