Unable to run koan using contemplate koans after update to PHP8.1

[LeWricka]

Due to the latest updates to PHP 8.1, running the koan using php contemplate_koans is not working anymore, see picture below:

We can improve the way koans are executed and we can simplify the project by avoiding running the koans using contemplate and run them using phpunit.

[miker]

Weird. According to the PHPUnit section of the README all they did was rename phpunit (or was it the PHAR binary?) to 'contemplate_koans'. Not saying you or this issue is wrong. It just seems weird as this doesn't seem to be the case after looking at your PR.

I haven't looked at any of the code for this project or done anything more than read the README to see if it's something I wanted to check out to get better with PHP.

This issue is nearly 6 months old and doesn't look to be acknowledged let alone addressed. Has the project been abandoned?

[akoebbe]

Sorry I’ve been absent from this project for so long. I hope to get back to it this week or next.

…

On Sun, Apr 9, 2023 at 3:20 AM Mike Reynolds ***@***.***> wrote: Weird. According to the phpunit section of the README <https://github.com/akoebbe/php_koans/blob/master/README.md#phpunit> all they did was rename phpunit (or was it the PHAR binary?) to 'contemplate_koans'. Not saying you or this issue is wrong. It just seems weird as this doesn't seem to be the case after looking at your PR. I haven't looked at any of the code for this project or done anything more than read the README to see if it's something I wanted to check out to get better with PHP. This issue is nearly 6 months old and doesn't look to be acknowledged let alone addressed. Has the project been abandoned? — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH674OADO4QAWSSFPMC7XDXAJWKRANCNFSM6AAAAAASP22SGA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[LeWricka]

Hi, @akoebbe in our case (we are a small company) we could like to help evolving the project. That's the reason for the issue and the pull request updating and simplifying the project.

If the idea is to maintain it, we could help adding more koans.

[miker]

Sorry I’ve been absent from this project for so long. I hope to get back to it this week or next.

No worries, real life definitely gets in the way. Glad to hear you are still working on this. I always liked the idea of doing koans to help with learning a language. Looking forward to more koans being added.

I hope to have time today to check out the project in it's current state. Any info on this issue?

Also what version of PHP is the project actually targeting?

LeWricka awesome of you (and your company) offering to assist adding koans!

[LeWricka]

Hey! coming back to this. @akoebbe is there any chance to keep going with the koans? We Ithink it is an interesting tool and we could like to invest time on it, but we are block since some months.
Can we keep going somehow? I could like to avoid forking the project, I think is better for everyone to keep going on this base :)

[akoebbe]

Hey @LeWricka. I definitely want to keep going on this. I am sorry for not having the time to stay on top of this. I did try to get make some progress awhile back but I ended up hitting some trouble doing what I wanted to. There are a few issues that I'd like to get resolved before people spend too much time with new koans. I'll make separate issues so that either I or anyone else can try to address them.

1. phpunit no longer supports custom printers, which is what I was using to make the phpunit output more user friendly for newer programmers. (update: maybe this is a pattern we could follow?)
2. I don't want to have to manually check-in the phpunit.phar (renamed contemplate_koans in this repo) when there is a phpunit version bump. My main concern is that someone would submit a PR with a malicious version and there would be no checks. I'd like to get some sort of github actions pipeline going that would automatically pull in the latest version of phpunit.phar and rename it to contemplate_koans
   • There might be a question "Why not just use a composer file to include phpunit?" This is because I want the curve for new developers to be very shallow. I do not want them to have to learn what composer is, how to install it, and install the dependencies. Even after all of that, actually executing phpunit is not straight forward and might scare people away.

So these are the two main roadblocks I see. Perhaps I'm getting ahead of myself and these issues are pointless if there aren't enough koans for people to use.

[LeWricka]

@akoebbe sorry for not answering in a while.
Have a look at this PRs, it changes the way we used to work in the repo.
Also due to the rhythm on this repo we have keep going here: https://github.com/540/php_koans but we could keep going here if you want