Skip to content

Commit

Permalink
Remove internal commands from keybindings widget
Browse files Browse the repository at this point in the history
Fixes eclipse-theia#6368

- remove internal commands (commands prefixed by `_`) from the
keybindings widget. These commands should not be displayed to
end users as they should not be updated.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
  • Loading branch information
vince-fugnitto authored and akosyakov committed Feb 24, 2020
1 parent ba36d34 commit 757d1c2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/keymaps/src/browser/keybindings-widget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,10 @@ export class KeybindingWidget extends ReactWidget {
const items: KeybindingItem[] = [];
// Build the keybinding items.
for (let i = 0; i < commands.length; i++) {
// Skip internal commands prefixed by `_`.
if (commands[i].id.startsWith('_')) {
continue;
}
// Obtain the keybinding for the given command.
const keybindings = this.keybindingRegistry.getKeybindingsForCommand(commands[i].id);
const item: KeybindingItem = {
Expand Down

0 comments on commit 757d1c2

Please sign in to comment.