Create iframe conditional on options and hashchange and pushstate support #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Proxy an iframe to handle location events if the browser doesn't | ||
| // support the `hashchange` event, HTML5 history, or the user wants | ||
| // `hashChange` but not `pushState`. | ||
| if (!_.hasHashChange && _.wantsHashChange && |
There was a problem hiding this comment.
80 chars isn't a hard limit. I think it's cleaner all on one line.
| // Proxy an iframe to handle location events if the browser doesn't | ||
| // support the `hashchange` event, HTML5 history, or the user wants | ||
| // `hashChange` but not `pushState`. | ||
| if (!_.hasHashChange && _.wantsHashChange && (!_.wantsPushState || !_.hasPushState)) { |
There was a problem hiding this comment.
Typos here _.hasHashChange -> this._hasHashChange & friends.
|
@akre54 how's this PR look now? |
akre54
added a commit
that referenced
this pull request
Feb 27, 2014
Create iframe conditional on options and hashchange and pushstate support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests passed on IE6 - 11, and the latest Chrome, Firefox and Safari.