Fix tests for Chaplin#780 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| matchesSelector: (node, selector) -> | ||
| matchesSelector = node.matches || node.webkitMatchesSelector || node.mozMatchesSelector || node.msMatchesSelector | ||
| matchesSelector.call(node, selector) | ||
|
|
There was a problem hiding this comment.
Not sure DOM manipulation belongs to Chaplin
There was a problem hiding this comment.
Agreed. But maybe we could use something like https://github.com/akre54/Backbone.NativeView/blob/0.3.2/backbone.nativeview.js#L34-L48 that has older browser support and eagerly finds the selector... if we really need it
|
All done. I've also changed the call to |
|
Awesome. Thanks. |
|
Meh. I see Travis still fail in the original PR. I must have fucked up something with Grunt when i've rerunned the tests. Won't have time to work on this before Monday, but i'll sent another PR ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd really like to see chaplinjsgh-780 merged, so i tried to fix the failling tests.
I had to update grunt-mocha due to some inability to install PhantomJS.
I'm not completly happy with this PR, i'll comment in the code.
Also, i didn't try to see if tests are OK without deps, i'd prefer adress eventuals comments before going on with this