Skip to content
This repository has been archived by the owner on Oct 10, 2019. It is now read-only.

text-width should not be used unless window is large enough #602

Open
gmarmstrong opened this issue Oct 11, 2017 · 1 comment
Open

text-width should not be used unless window is large enough #602

gmarmstrong opened this issue Oct 11, 2017 · 1 comment

Comments

@gmarmstrong
Copy link

Version: 2.9.

The text-width setting should be ignored if the window not wide enough to hold that many columns.

To reproduce, set text-width to 80, shrink the window to fewer than 80 columns, and view an article. Blocks of text will be improperly wrapped.

Expected (default) behavior:
good

Actual (text-width 80) behavior:
bad

The text-width option should not be used unless the window is large enough. If the window is too small, fall back to the default wrapping behavior.

@Minoru
Copy link
Collaborator

Minoru commented Oct 12, 2017

(Oops, didn't know the issue will be closed using a commit from another repo! Will keep this in mind in the future.)

@gmarmstrong, Newsbeuter is no longer maintained, but I implemented your idea in my fork. Thanks for bringing this up!

0-wiz-0 pushed a commit to NetBSD/pkgsrc-wip that referenced this issue Dec 26, 2017
Lists below only mention user-visible changes, but I would also like to
acknowledge contributions from the following people: Alok Singh, Carno, Jonas
Karlsson, Kamil Wsół, Mike Crute, Niels Kobschätzki, and maiki.

- HTML anchors for all config commands in docs. You can now link to each command
    separately (#10) (Lysander Trischler)
- Support for Inoreader (Bart Libert)
- Slovak translation (František Hájik)

- Enqueue *last* audio enclosure
    (akrennmair/newsbeuter#604)
- `text-width` doesn't apply if it's bigger than terminal width
    (akrennmair/newsbeuter#602)
- Translations: German (Lysander Trischler), Russian, Ukrainian
    (Alexander Batischev)

- Build dependency on Perl (#6)
- Test dependency on bc (Nikos Tsipinakis)

- Do not create XDG data dir if not using XDG (#8)
- When used with Newsblur, check on startup if cookie-cache exists or can be
    created, because integration doesn't work without cookies (#13)
- Builds on AARCH64 and ARMHF (#43)
- Only show an error message once when unknown option is supplied
    (Lysander Trischler)
- License header used to say it's MIT/X Consortium License, whereas in reality
    it's a MIT License (discovered by Nikos Tsipinakis)
- Cross-compilation made possible by conditionally assigning to RANLIB and AR in
    Makefile (Fredrik Fornwall)
- Cookies actually get persisted (Simon Schuster, reported and tested by Håkan
    Jerning)
- CJK text is wrapped at correct code-point boundaries (#71) (nmtake)
- Don't segfault if `error-log` points to non-existent file (Simon Schuster)
- Spanish translation (José Manuel García-Patos)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants