fixes a bash syntax error with BUILD_RESTRICT_LANG and some English #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvalyi
force-pushed
the
master-BUILD_RESTRICT_LANG-fix
branch
from
7675f7b
to
a78626e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as for BUILD_RESTRICT_LANG, you can try not setting BUILD_RESTRICT_LANG in your odoo/Dockerfile and the build will fail. Now it works again (if [[ "-n $SOME_ENV_VAR" ]] is the proper way to avoid blank values as well https://stackoverflow.com/a/14900557 )
Also, I inform you I fixed the bad "rebuild the world" we experience once a week on the CI after Acsone updates the bedrock base image weekly. I used a multi-steps build image, I'll create other PRs for it. It will save the Akretion CI from downloading over 200 Gb from Github every week easily... And also saves a solid ~6Gb weekly per deploy to the production servers...
We couldn't live with that with our bandwidth limitations in Brazil...
cc @sebastienbeau @hparfr @PierrickBrun