-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adom Lock with Contextmanager #30
Conversation
Added commits 946394 and e108e3a with ContextManagers. The goal is to avoid leaving open sessions and/or stale ADM locks should your code have an issue between open and close, you can call this library like so:
instead of
|
Done.
|
Hello, It seems there is a missing "return self" in the enter method of FortiManager. This make the with statement giving None Object ! |
Oops... well this PR is already merged, I'd need a new one, can't you fix this yourself? |
This PR adds a couple extras like removing unused imports and a dangerous default "{}" in a function call
Breaking changes:
It looks enormous because of the formatting I've run on it.