[V3] Update react-native-experimental-navigation to new version with PropTypes fix

[daviscabral]

This PR is dependent of aksonov/react-native-experimental-navigation#31 (where the version is updated).

Babel presets and plugins were also updated in the process.

[daviscabral]

@aksonov any objection in going forward with this kind of update? That’s the maintenance of v3 that I would like to keep - that I told you about in #69.

[ujwal-setlur]

@daviscabral , don't you need to change the import statements to import reactxp-experimental-navigation instead of react-native-experimental-navigation? For example, in Router.js:

import NavigationExperimental from 'react-native-experimental-navigation';

I would imagine this import statement would have to change to reference reactxp-experimental-navigation.

[daviscabral]

@ujwal-setlur good catch! I was under the impression I had committed those changes. I'll get those committed and pushed now.

[schlaegerz]

I tried using this branch and it doesn't seem to work.
Router.js is doing the following:

const {
  RootContainer: NavigationRootContainer,
} = NavigationExperimental;

And the branch you are using doesn't have RootContainer defined as part of NavigationExperimental

[daviscabral]

@schlaegerz you are totally right. I know what happened - I've have in my app with a custom reducer and router - what made I miss it. My bad - I'll work in a proper fix. Probably worth to patch http://github.com/aksonov/react-native-experimental-navigation instead of moving over a totally different project.

[daviscabral]

Working to fix this right now 👍

[daviscabral]

I am with a new local branch working in a way to bring useNativeDriver to the animations - but it seems that is really broken. Not sure if worth the trouble. I'll keep cleaning up stuff to react 16.0.0.

[ujwal-setlur]

Let me know if you need any help. I really want to move to react-native 0.49 and react 16, and this issue is stopping me :)

[schlaegerz]

Thank you so much! After fixing the last of the PropTypes issues and using this branch I was finally able to get it all working again.

[daviscabral]

@schlaegerz glad to know. I changed my mind about using the MS fork - it seems they made a lot of changes there to use it with Skype. Not sure if the whole work to make it functional with v3 makes sense. An upgrade to v4 sounds more sensate.

[ujwal-setlur]

@daviscabral This is not working for me. I took the latest from your dc-use-react-native-experimental-navigation-from-ms branch. I still get the following error:

Looking at the code, it seems you are still importing "PropTypes" from react, and not prop-types?

[daviscabral]

@ujwal-setlur try to remove your node_modules and clean your npm cache. I got the same issue here, and since we haven't bumped the version yet - it was still getting the same old package. Let me know if that does not work.

[schlaegerz]

There were some leftover propTypes, i branched this one myself, if you want to just test out a temporary branch https://github.com/schlaegerz/react-native-router-flux/tree/dc-use-react-native-experimental-navigation-from-ms

[daviscabral]

Good catch! My bad! 👍

[ujwal-setlur]

Yay, it works with this now! Thanks!

[ujwal-setlur]

@daviscabral it looks like react-native-experimental-navigation 0.28.0 uses React.PropTypes. That needs to be cleaned out as well. Bummer, so much cleanup work!

[aksonov]

Looks like 0.28 was published before your changes. I’ve just published 0.29, please check

…

On 26 Oct 2017, at 18:44, Ujwal Setlur ***@***.***> wrote: @daviscabral <https://github.com/daviscabral> it looks like react-native-experimental-navigation 0.28.0 uses React.PropTypes. That needs to be cleaned out as well. Bummer, so much cleanup work! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2541 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpcWG-5EWnr0BItc0y6zP2VQ6kcaFYks5swLb2gaJpZM4QEb8W>.

[ujwal-setlur]

@aksonov thanks! I just forked the repo to make the changes. Glad I don't have to!

@daviscabral can you update your branch to use 0.29.0?

[ujwal-setlur]

@aksonov there were duplicate require statements in two files. I have fixed that and raised a pull request: aksonov/react-native-experimental-navigation#32

[aksonov]

Does component fails now?

…

26 окт. 2017 г., в 19:57, Ujwal Setlur ***@***.***> написал(а): @aksonov there were duplicate require statements in two files. I have fixed that and raised a pull request: aksonov/react-native-experimental-navigation#32 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[ujwal-setlur]

Yes it refuses to build because of the duplicate require statements

[aksonov]

Done, published 0.29.1

[ujwal-setlur]

Thanks!

[ujwal-setlur]

@aksonov thanks for meeting my PR. How about this PR from @daviscabral. I have tested it and it works. @daviscabral needs to update it to use 0.29.1 of react-native-experimental-navigation

[daviscabral]

I am not home now - but should be there soon to update it 👍🏻

[daviscabral]

Did some cleanup in the commits.

@aksonov Any chance of this getting merged?

[aksonov]

@daviscabral Could you set 0.29.1 as react-native-experimental-navigation ?

[daviscabral]

Yes - sorry - forgot to update it inside the Example folder.

[daviscabral]

@aksonov Done 👍🏻

[daviscabral]

Thank you.

[ujwal-setlur]

Thanks @daviscabral and @aksonov. Will there be a new release?

Also, @aksonov, how hard is the migration from v3 to v4? I use switch which I believe is not there in v4?

[daviscabral]

@ujwal-setlur it's there already - 3.42.

[ujwal-setlur]

@daviscabral Oh, OK. I thought 3.42 was published before your merge.

[ujwal-setlur]

@daviscabral @aksonov I just checked and 3.42.0 does not have this pull request. In DefaultRenderer.js:

import React, {
  PureComponent,
  PropTypes,
} from 'react';

We need a 3.43.0 or 3.42.1

[aksonov]

Done, 3.43.0

…

On 27 Oct 2017, at 19:42, Ujwal Setlur ***@***.***> wrote: @daviscabral <https://github.com/daviscabral> @aksonov <https://github.com/aksonov> I just checked and 3.42.0 does not have this pull request. In DefaultReneder.js: import React, { PureComponent, PropTypes, } from 'react'; We need a 3.43.0 or 3.42.1 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2541 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpcVv46E4oH1-FFc37WpmUh8oMlzPEks5swhYOgaJpZM4QEb8W>.

[ujwal-setlur]

That was quick 👍 Thanks!