Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rebuild if default_precision would not change #106

Merged
merged 3 commits into from
Jul 9, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 9, 2023

Closes #105, which explains the rationale for this fix

Here is a proposed patch to avoid rebuilding bigdecimal always

I tested locally with

cargo test
cargo test
cargo test
..

With this patch the subsequent calls to cargo test do not force a rebuild

@alamb
Copy link
Contributor Author

alamb commented Jul 9, 2023

cc @akubera

Copy link
Owner

@akubera akubera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah that makes sense. I must have thought it checked the contents rather than modtimes.

Here are some suggestions to make it compatible with older versions of Rust.

build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
alamb and others added 2 commits July 9, 2023 18:53
Co-authored-by: Andrew Kubera <andrewkubera@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #106 (94e1d42) into trunk (b80509a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##            trunk     #106   +/-   ##
=======================================
  Coverage   75.64%   75.64%           
=======================================
  Files           8        8           
  Lines        2004     2004           
  Branches     2004     2004           
=======================================
  Hits         1516     1516           
  Misses         82       82           
  Partials      406      406           

@akubera akubera merged commit 88d049b into akubera:trunk Jul 9, 2023
@alamb alamb deleted the alamb/norebuild branch July 10, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigdecimal 0.4.0 always forces a rebuild (on mac)
3 participants