Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: empty verifications tab in stage details #3076

Closed
3 of 4 tasks
Marvin9 opened this issue Dec 5, 2024 · 2 comments · Fixed by #3169
Closed
3 of 4 tasks

UI: empty verifications tab in stage details #3076

Marvin9 opened this issue Dec 5, 2024 · 2 comments · Fixed by #3169

Comments

@Marvin9
Copy link
Contributor

Marvin9 commented Dec 5, 2024

Checklist

  • I've searched the issue queue to verify this is not a duplicate bug report.
  • I've included steps to reproduce the bug.
  • I've pasted the output of kargo version.
  • I've pasted logs, if applicable.

Description

Stages who don't have verification in spec are having verification history in status when promoted. This is populating empty verification entries in UI

Screenshots

Screenshot 2024-12-05 at 6 16 47 PM (2)

Steps to Reproduce

  • Create stage without verification in spec
  • Promote to that stage
  • Open stage details in UI and go to Verifications tab

Version

main

Logs

Paste any relevant application logs here.
@Marvin9 Marvin9 changed the title UI: empty verifications UI: empty verifications tab in stage details Dec 5, 2024
@krancour
Copy link
Member

krancour commented Dec 6, 2024

This was a deliberate change. When there's no user-defined verification process, verification is implicit when a Stage becomes healthy for the first time following recent promotion. Things have always worked this way. It's just that we didn't used to make a record of it and now we do. Having that record simplifies a lot of other things.

I actually find it nice that these show up in the UI as well. It makes it more clear that some kind of verification did indeed take place.

@jessesuen jessesuen modified the milestone: v1.1.1 Dec 6, 2024
@jessesuen
Copy link
Member

I was caught off guard by this change, but can understand how it could be useful.

That said, if my Stage doesn't have verification defined, I wouldn't expect entries in my verification tab. And the empty columns don't really display any useful information. At the least, I suggest we offer a checkbox to filter out these "implicit" verifications.

@Marvin9 Marvin9 self-assigned this Dec 6, 2024
@Marvin9 Marvin9 modified the milestones: v1.1.1, v1.1.2 Dec 6, 2024
@krancour krancour modified the milestones: v1.1.2, v1.2.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants