fix(ui): implicit verification filter #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Marvin9
commented
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3169 +/- ##
==========================================
+ Coverage 51.35% 51.40% +0.05%
==========================================
Files 287 288 +1
Lines 26022 26108 +86
==========================================
+ Hits 13363 13421 +58
- Misses 11938 11961 +23
- Partials 721 726 +5 ☔ View full report in Codecov by Sentry. |
|
Feature works great @Marvin9! I suggested a wording change and then this LGTM. |
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com> Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Marvin9
force-pushed
the
Marvin9/fix-empty-verification-tab
branch
from
05f0ecd to
2b5c7d9
Compare
krancour
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3076
shows filter only if implicit verifications meta exist in recent verifications.
default not to show those.