Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhooks): validate Freight during creation #2118

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Jun 5, 2024

This adds more validation logic for the creation of Freight, ensuring that Freight contains precisely one artifact for each subscription of the Warehouse it references.

Fixes #2117

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 54a603b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6668a7d41b164a0008a7df58
😎 Deploy Preview https://deploy-preview-2118.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 98.60140% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.56%. Comparing base (086477e) to head (54a603b).
Report is 8 commits behind head on main.

Files Patch % Lines
internal/webhook/freight/webhook.go 98.60% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
+ Coverage   45.93%   46.56%   +0.62%     
==========================================
  Files         238      239       +1     
  Lines       16542    16741     +199     
==========================================
+ Hits         7599     7795     +196     
- Misses       8571     8573       +2     
- Partials      372      373       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco enabled auto-merge June 11, 2024 19:39
@hiddeco hiddeco added this pull request to the merge queue Jun 11, 2024
Merged via the queue into akuity:main with commit 9aa396b Jun 11, 2024
17 checks passed
@hiddeco hiddeco deleted the freight-validation branch June 11, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freight creation validating webhook
2 participants