Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support kustomize image newName override #2471

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Aug 27, 2024

This is the manual cherry-pick of #2470 to the release-0.8 branch. Automatic cherry-pick failed because of codegen conflicts since the backport involves a change to the API type.

Signed-off-by: Jesse Suen <jesse@akuity.io>
@jessesuen jessesuen requested a review from a team as a code owner August 27, 2024 20:42
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 422eea5
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66ce3a2c4d3833000839c6e2

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.72%. Comparing base (dc2c81b) to head (422eea5).
Report is 1 commits behind head on release-0.8.

Files Patch % Lines
internal/controller/promotion/kustomize.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.8    #2471      +/-   ##
===============================================
- Coverage        46.72%   46.72%   -0.01%     
===============================================
  Files              246      246              
  Lines            17747    17750       +3     
===============================================
+ Hits              8292     8293       +1     
- Misses            9025     9026       +1     
- Partials           430      431       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessesuen jessesuen merged commit a0a4456 into akuity:release-0.8 Aug 27, 2024
28 checks passed
@jessesuen jessesuen deleted the feat/kustomize-newName-0.8 branch August 27, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants