chore(deps/tools): bump the go-minor group in /hack/tools with 2 updates #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the go-minor group in /hack/tools with 2 updates: [github.com/bufbuild/buf](https://github.com/bufbuild/buf) and [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint). Updates `github.com/bufbuild/buf` from 1.46.0 to 1.47.2 - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.46.0...v1.47.2) Updates `github.com/golangci/golangci-lint` from 1.61.0 to 1.62.0 - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.61.0...v1.62.0) --- updated-dependencies: - dependency-name: github.com/bufbuild/buf dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-minor - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Faeka Ansari <faeka6@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2947 +/- ##
=======================================
Coverage 50.92% 50.92%
=======================================
Files 279 279
Lines 25180 25180
=======================================
Hits 12823 12823
Misses 11666 11666
Partials 691 691 ☔ View full report in Codecov by Sentry. |
krancour
reviewed
Nov 18, 2024
Comment on lines
+154
to
+157
| - name: redefines-builtin-id | ||
| # Disabled as the use of identifiers similar to built-ins is intentional | ||
| # and does not cause any runtime or functional issues. | ||
| disabled: true |
There was a problem hiding this comment.
What were some specific things that were getting flagged?
There was a problem hiding this comment.
new', 'min', and append` identifiers shadowed the names of Go's built in functions
There was a problem hiding this comment.
Error:
internal/rollouts/analysis_template.go:127:59: redefines-builtin-id: redefinition of the built-in function new (revive)
func validateAndUpdateArg(existing *rolloutsapi.Argument, new rolloutsapi.Argument) error {
^
internal/controller/stages/event_handlers.go:133:34: redefines-builtin-id: redefinition of the built-in function new (revive)
func getNewlyVerifiedStages(old, new *kargoapi.Freight) []string {
^
internal/controller/stages/event_handlers.go:211:34: redefines-builtin-id: redefinition of the built-in function new (revive)
func getNewlyApprovedStages(old, new *kargoapi.Freight) []string {
^
internal/image/selector_docker_hub_test.go:314:3: redefines-builtin-id: redefinition of the built-in function min (revive)
min := semver.MustParse("12.0.0")
^
internal/image/selector_docker_hub_test.go:359:3: redefines-builtin-id: redefinition of the built-in function min (revive)
min := semver.MustParse("12.0.0")
^
internal/image/selector_ghcr_test.go:172:3: redefines-builtin-id: redefinition of the built-in function min (revive)
min := semver.MustParse("0.1.0")
^
internal/directives/helm_template_runner.go:279:66: redefines-builtin-id: redefinition of the built-in function append (revive)
func writeToHelmFile(outputDir string, name string, data string, append bool) (err error) {
^
internal/directives/helm_template_runner.go:305:44: redefines-builtin-id: redefinition of the built-in function append (revive)
func createOrOpenHelmFile(filename string, append bool) (*os.File, error) {
^There was a problem hiding this comment.
As these are easily fixed, I'd prefer seeing us do so instead of disabling this linter. By disabling it, we're stopping it from finding future problems that might be more genuinely troublesome than these are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the go-minor group in /hack/tools with 2 updates: github.com/bufbuild/buf and github.com/golangci/golangci-lint.
Updates
github.com/bufbuild/buffrom 1.46.0 to 1.47.2Release notes
Sourced from github.com/bufbuild/buf's releases.
Changelog
Sourced from github.com/bufbuild/buf's changelog.
Commits
13828a3Release v1.47.2 (#3472)be349d1Return to development (#3471)8688d16Release v1.47.1 (#3470)d12a559Return to development (#3467)3f619b8Release v1.47.0 (#3466)5fda66bMove registry commit and label commands under modules (#3454)10ddcf5Add bufplugin package (#3431)dae748fMake upgrade (#3463)4343d43Do not format a file that contains an error in the LSP (#3447)62082b2Adjust cacheModuleDataProviderto re-retrieve delegate values from store a...Updates
github.com/golangci/golangci-lintfrom 1.61.0 to 1.62.0Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
Commits
22b58c9build(deps): bump go-simpler.org/musttag from 0.12.2 to 0.13.0 (#5121)84c203abuild(deps): bump github.com/lasiar/canonicalheader from 1.1.1 to 1.1.2 (#5119)0f4f0cbbuild(deps): bump golang.org/x/tools from 0.26.0 to 0.27.0 (#5120)02a536abuild(deps): bump golang.org/x/sys from 0.26.0 to 0.27.0 (#5118)b46ad10docs: improve forbidigo pattern examples for built-in functions (#5116)8c0c515fix: Go version propagation (#5109)874a8bafeat: deprecation step 2 of execinquery and gomnd (#5110)6ba5f63build(deps): bump github.com/mgechev/revive from 1.4.0 to 1.5.0 (#5113)c4b6d37build(deps): bump github.com/nunnatsa/ginkgolinter from 0.17.0 to 0.18.0 (#5114)7560b4ffix: improve Go detection (#5112)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions