fix(ui): stage phase icon #3164
Merged
+184
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3164 +/- ##
==========================================
+ Coverage 51.37% 51.40% +0.02%
==========================================
Files 285 288 +3
Lines 25763 26108 +345
==========================================
+ Hits 13236 13421 +185
- Misses 11825 11961 +136
- Partials 702 726 +24 ☔ View full report in Codecov by Sentry. |
|
When I test drive this, I'm seeing the phase icon always gray/not applicable, no matter what the actual phase is. Example:
|
|
fixed it. sorry I hardcoded when testing and forgot to revert |
krancour
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2776
stage health icon remains right to phase icon
Screen.Recording.2024-12-19.at.3.45.57.PM.mov
Screen.Recording.2024-12-19.at.3.44.44.PM.mov
I started this while back but put on hold. Let me know if
stage.status.phaseis not good place to look for this info - @hiddeco @krancour