Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement project details live refresh #574

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

alexmt
Copy link
Contributor

@alexmt alexmt commented Aug 16, 2023

Closes #569

PR implements project details page live refresh. Unfortunately, connect-es does not support streaming. So I had to implement SSE based streaming.

Streaming is implemented using connect-es

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 3e19c25
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/64ddacb0137c650008d236df

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #574 (3e19c25) into main (3c5885d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   44.59%   44.58%   -0.01%     
==========================================
  Files          74       74              
  Lines        5122     5123       +1     
==========================================
  Hits         2284     2284              
- Misses       2734     2735       +1     
  Partials      104      104              
Files Changed Coverage Δ
internal/api/handler/watch_stages_v1alpha1.go 0.00% <0.00%> (ø)

@alexmt alexmt marked this pull request as draft August 17, 2023 00:35
@alexmt alexmt force-pushed the proj-details-live-update branch 2 times, most recently from 298ea60 to 292da98 Compare August 17, 2023 03:52
@alexmt alexmt marked this pull request as ready for review August 17, 2023 03:53
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Copy link
Member

@devholic devholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment 👍

api/service/v1alpha1/service.proto Outdated Show resolved Hide resolved
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt merged commit d9f9f7b into main Aug 17, 2023
13 of 15 checks passed
@alexmt alexmt deleted the proj-details-live-update branch August 17, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live update of Stages
2 participants