Skip to content

Commit

Permalink
Review fixes 3
Browse files Browse the repository at this point in the history
  • Loading branch information
dsame committed Jun 16, 2023
1 parent 3ef5272 commit 17a4854
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 11 deletions.
8 changes: 0 additions & 8 deletions __tests__/cache-save.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,6 @@ describe('run', () => {
expect(getStateSpy).toHaveBeenCalledTimes(3);
expect(getCommandOutputSpy).toHaveBeenCalledTimes(0);
expect(debugSpy).toHaveBeenCalledTimes(0);
/*
expect(debugSpy).toHaveBeenCalledWith(
'Consumed yarn version is 2.2.3 (working dir: "")'
);
expect(debugSpy).toHaveBeenCalledWith(
'yarn\'s cache folder "/some/random/path/yarn2" configured for the root directory'
);
*/
expect(infoSpy).toHaveBeenCalledWith(
`Cache hit occurred on the primary key ${yarnFileHash}, not saving cache.`
);
Expand Down
1 change: 0 additions & 1 deletion dist/cache-save/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -60516,7 +60516,6 @@ const getProjectDirectoriesFromCacheDependencyPath = (cacheDependencyPath) => __
const existingDirectories = cacheDependenciesPaths
.map(path_1.default.dirname)
.filter(util_1.unique())
.filter(fs_1.default.existsSync)
.filter(directory => fs_1.default.lstatSync(directory).isDirectory());
if (!existingDirectories.length)
core.warning(`No existing directories found containing cache-dependency-path="${cacheDependencyPath}"`);
Expand Down
1 change: 0 additions & 1 deletion dist/setup/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -71299,7 +71299,6 @@ const getProjectDirectoriesFromCacheDependencyPath = (cacheDependencyPath) => __
const existingDirectories = cacheDependenciesPaths
.map(path_1.default.dirname)
.filter(util_1.unique())
.filter(fs_1.default.existsSync)
.filter(directory => fs_1.default.lstatSync(directory).isDirectory());
if (!existingDirectories.length)
core.warning(`No existing directories found containing cache-dependency-path="${cacheDependencyPath}"`);
Expand Down
1 change: 0 additions & 1 deletion src/cache-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ const getProjectDirectoriesFromCacheDependencyPath = async (
const existingDirectories: string[] = cacheDependenciesPaths
.map(path.dirname)
.filter(unique())
.filter(fs.existsSync)
.filter(directory => fs.lstatSync(directory).isDirectory());

if (!existingDirectories.length)
Expand Down

0 comments on commit 17a4854

Please sign in to comment.