fix(popover): hide when host was removed (#430)

akveo · May 19, 2018 · a07496d · a07496d
1 parent ca81f90
commit a07496d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/e2e/popover.e2e-spec.ts b/e2e/popover.e2e-spec.ts
@@ -164,4 +164,13 @@ describe('nb-popover', () => {
     const text = element(popover).element(by.css('nb-dynamic-to-add > div > strong')).getText();
     expect(text).toEqual('hello from dynamically inserted component: Example context');
   });
+
+  it('have to hide popover when host removed', done => {
+    element(contentTemplate).click();
+    expect(element(popover).isPresent()).toBeTruthy();
+    browser.get('#/').then(() => {
+      expect(element(popover).isPresent()).toBeFalsy();
+      done();
+    })
+  });
 });
diff --git a/src/framework/theme/components/popover/popover.directive.ts b/src/framework/theme/components/popover/popover.directive.ts
@@ -167,6 +167,7 @@ export class NbPopoverDirective implements OnInit, OnDestroy {
 
   ngOnDestroy() {
     this.alive = false;
+    this.hide();
   }
 
   /**
-Original file line number
+Diff line change
@@ Expand Up @@
       ngOnDestroy() {
         this.alive = false;
+        this.hide();
       }
       /**
@@ Expand Down @@