fix(icon): fix NULL content render in MS Edge (#2043)

akveo · Oct 31, 2019 · f37223a · f37223a
1 parent a15c81d
commit f37223a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/framework/theme/components/icon/icon.component.ts b/src/framework/theme/components/icon/icon.component.ts
@@ -115,7 +115,7 @@ export class NbIconComponent implements NbIconConfig, OnChanges, OnInit {
   protected prevClasses = [];
 
   @HostBinding('innerHtml')
-  html: SafeHtml;
+  html: SafeHtml = '';
 
   @HostBinding('class.status-primary')
   get primary() {

diff --git a/src/framework/theme/components/icon/icon.spec.ts b/src/framework/theme/components/icon/icon.spec.ts
@@ -138,4 +138,12 @@ describe('NbIconComponent', () => {
     iconComponent.config = null;
     expect(iconComponent.config).toEqual(config);
   });
+
+  it('icon inner html not to be null or undefined', () => {
+    const iconComponent: NbIconComponent = TestBed.createComponent(NbIconComponent).componentInstance;
+    iconComponent.config = { icon: 'test-not-existing-icon' };
+
+    expect(iconComponent.html).not.toBeNull();
+    expect(iconComponent.html).not.toBeUndefined();
+  });
 });