fix(icon): fix NULL content render in MS Edge #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2043 +/- ##
=======================================
Coverage 84.28% 84.28%
=======================================
Files 235 235
Lines 7905 7905
Branches 695 695
=======================================
Hits 6663 6663
Misses 1039 1039
Partials 203 203
|
|
This is a nicer fix than my PR, and includes tests. I'll close mine 👍 |
yggg
approved these changes
Oct 31, 2019
This was referenced Oct 31, 2019
|
Great Thanks guys |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fix icon inner html NULL in MS Edge (#1962)