Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nb-icon with font-awesome pack rendering null content on Microsoft Edge #2021

Closed
1 of 2 tasks
mhartz82 opened this issue Oct 16, 2019 · 1 comment
Closed
1 of 2 tasks

Comments

@mhartz82
Copy link

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:
Using an nb-icon with font-awesome pack on Microsoft Edge the icon correctly appears, but after it a null content is rendered.

rendering

code

Expected behavior:
Only the icon has to be rendered.

Steps to reproduce:
Register font-awesome icons like this:

iconLibraries.registerFontPack('font-awesome', { iconClassPrefix: 'fa', packClass: 'fas' });

and then use them like this:

<nb-icon icon="euro-sign" pack="font-awesome"></nb-icon>

Also your ngx-admin demo reproduces the problem: https://akveo.com/ngx-admin/pages/ui-features/icons

Other information:

npm, node, OS, Browser

Browser: Edge
@yggg
Copy link
Contributor

yggg commented Nov 4, 2019

Fixed in Nebular 4.5.0 by #2043.

@yggg yggg closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants