-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): highlight when active anchors #1034
Conversation
Let's keep it opened until #1041 will be resolved. I have some ideas on how to completely solve this challenge but we can't be sure that all the things work fine without tests. |
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
- Coverage 80.68% 80.68% -0.01%
==========================================
Files 232 232
Lines 7032 7041 +9
Branches 593 595 +2
==========================================
+ Hits 5674 5681 +7
- Misses 1184 1185 +1
- Partials 174 175 +1
|
Let's write regression tests for NbMenuComponent. Which verify that fragment selection works properly. |
@yggg tests are failing :( |
I've fixed unit tests but looks like something is wrong with browser stack tunnel. |
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #875