Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): highlight when active anchors #1034

Merged
merged 13 commits into from
Mar 31, 2019

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Nov 30, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #875

@Tibing Tibing requested a review from nnixaa November 30, 2018 16:46
@Tibing
Copy link
Member Author

Tibing commented Dec 7, 2018

Let's keep it opened until #1041 will be resolved. I have some ideas on how to completely solve this challenge but we can't be sure that all the things work fine without tests.

@nnixaa nnixaa added the blocked label Dec 11, 2018
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #1034 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   80.68%   80.68%   -0.01%     
==========================================
  Files         232      232              
  Lines        7032     7041       +9     
  Branches      593      595       +2     
==========================================
+ Hits         5674     5681       +7     
- Misses       1184     1185       +1     
- Partials      174      175       +1
Impacted Files Coverage Δ
...work/theme/components/menu/url-matching-helpers.ts 100% <100%> (ø) ⬆️
...rc/framework/theme/components/menu/menu.service.ts 65.24% <71.42%> (-0.45%) ⬇️

@yggg yggg removed the blocked label Feb 27, 2019
@Tibing
Copy link
Member Author

Tibing commented Mar 29, 2019

Let's write regression tests for NbMenuComponent. Which verify that fragment selection works properly.

@nnixaa
Copy link
Collaborator

nnixaa commented Mar 31, 2019

@yggg tests are failing :(

@yggg
Copy link
Contributor

yggg commented Mar 31, 2019

I've fixed unit tests but looks like something is wrong with browser stack tunnel.

@nnixaa nnixaa merged commit c14215a into akveo:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbMenuItem is not applied 'active' styles if fragments are used in URL
4 participants