docs(menu): Fix selection highlight in menu service example

[miqh]

• I read and followed the CONTRIBUTING.md guide.
• I read and followed the New Feature Checklist guide.

---

Hello,

This is a very minor documentation fix.

I just noticed the menu service example doesn't correctly highlight one of the last items in the menu, presumably due to how the menu item is configured to match (i.e. full path by default).

[yggg]

Thanks for contribution @miqh 👍
Please see comment below.

[yggg]

I'm afraid there is no issue with configuration. Looks like the fix (#1034) aimed to include fragments into comparison doesn't work.

See here:

nebular/src/framework/theme/components/menu/menu.service.ts

Line 387 in f65a2cc

? isFragmentEqual(this.location.path(), item.fragment)

There are calls for isFragmentEqual and isFragmentContain functions which expecting path with the fragment. But this.location.path() doesn't return fragment unless you provide true as a parameter to the path function.

So a proper fix for the issue would be adding true as a parameter for this.location.path calls on lines 387 and 388.

Another thing to mention, there is plenty of tests for path and fragment comparison here and they all are passing. As turns out, SpyLocation used in unit tests as a mock for Location has no parameters for path method and always returns path with the fragment. I reported it here.
Until it's fixed in Angular it would be great to work around it somehow in Nebular tests.
I think we can extend SpyLocation, override path method to respect includeHash parameter and provide our extended class during TextBed configuration.
You can use helper functions from url-matching-helpers.ts.

What do you think? 🙂
Feel free to ping me here if you need any assistance.

[miqh]

Ah, I see, my mistake. I obviously didn't probe far enough into the underlying cause.