Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nb-select with empty value #1235

Closed
1 of 2 tasks
SashaSkywalker opened this issue Feb 14, 2019 · 3 comments
Closed
1 of 2 tasks

nb-select with empty value #1235

SashaSkywalker opened this issue Feb 14, 2019 · 3 comments

Comments

@SashaSkywalker
Copy link
Member

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Current behavior:
nb-select render empty string in label for option with empty value

Expected behavior:
nb-select should render option label

Steps to reproduce:

<nb-select>
  <nb-option value=''>first</nb-option>
  <nb-option value='2'>second</nb-option>
</nb-select>

if user selects first option then nothing will be rendered in label (bad)
if user selects second option then second will be rendered in label (good)

@theroozbeh
Copy link

theroozbeh commented Feb 28, 2019

The same thing happens when value equals to number 0 in case of assigning numbers to values.
for example:

<nb-select>
  <nb-option [value]="0">
     first
   </nb-option>
   <nb-option [value]="1">
     second
  </nb-option>
</nb-select>

or: https://stackblitz.com/edit/nb-select-zero-issue

@aefox
Copy link
Contributor

aefox commented Mar 7, 2019

PR for fix opened in #1282

@yggg yggg modified the milestones: 3.5.0, 4.0.0 Mar 28, 2019
Corey28 added a commit to momentum-mod/website that referenced this issue May 25, 2019
There is currently a little nb-select bug which has been fixed, but not released yet - see the issue here: akveo/nebular#1235
Be aware of this issue when using the nb-select component until the fix is released
Closes #326
@yggg
Copy link
Contributor

yggg commented May 27, 2019

Closing as fix (#1282) was merged

@yggg yggg closed this as completed May 27, 2019
Corey28 added a commit to momentum-mod/website that referenced this issue Jun 18, 2019
There is currently a little nb-select bug which has been fixed, but not released yet - see the issue here: akveo/nebular#1235
Be aware of this issue when using the nb-select component until the fix is released
Closes #326
Corey28 added a commit to momentum-mod/website that referenced this issue Jun 18, 2019
There is currently a little nb-select bug which has been fixed, but not released yet - see the issue here: akveo/nebular#1235
Be aware of this issue when using the nb-select component until the fix is released
Closes #326
Gocnak pushed a commit to momentum-mod/website that referenced this issue Jun 22, 2019
There is currently a little nb-select bug which has been fixed, but not released yet - see the issue here: akveo/nebular#1235
Be aware of this issue when using the nb-select component until the fix is released
Closes #326
Gocnak pushed a commit to momentum-mod/website that referenced this issue Jun 22, 2019
There is currently a little nb-select bug which has been fixed, but not released yet - see the issue here: akveo/nebular#1235
Be aware of this issue when using the nb-select component until the fix is released
Closes #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants