Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs more variables for checkbox component #143

Closed
1 of 2 tasks
tndrm opened this issue Jan 16, 2018 · 1 comment
Closed
1 of 2 tasks

Needs more variables for checkbox component #143

tndrm opened this issue Jan 16, 2018 · 1 comment
Assignees
@dimaatkaev
Labels
enhancement module:theme WIP
Milestone
rc.6

Comments

@tndrm
Copy link

tndrm commented Jan 16, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:
There are not enough variables for the hover and active state.
For example, it is impossible to configure the checkbox for this design:
image

Expected behavior:

Create new variables for hover and active checkbox state:

checkbox-selected-bg
checkbox-selected-fg
checkbox-active-bg
checkbox-active-fg
@nnixaa nnixaa added this to the rc.6 milestone Jan 22, 2018
@dimaatkaev
Copy link
Contributor

dimaatkaev commented Feb 1, 2018 •
edited
Loading

Proposed changes: update checkbox to have following settings:

  • checkbox-bg
  • checkbox-size
  • checkbox-border-size
  • checkbox-border-color
  • checkbox-checkmark
  • checkbox-checked-bg
  • checkbox-checked-size
  • checkbox-checked-border-size
  • checkbox-checked-border-color
  • checkbox-checked-checkmark
  • checkbox-disabled-bg
  • checkbox-disabled-size
  • checkbox-disabled-border-size
  • checkbox-disabled-border-color
  • checkbox-disabled-checkmark

@tndrm Could you please review preposition.

dimaatkaev pushed a commit to dimaatkaev/nebular that referenced this issue Feb 8, 2018
docs (chechbox): update demo themes and docs
aab0860 
Closes akveo#143
BREAKING CHANGE: Checkbox check mark color variable (radio-fg) was expanded.
There are tree variables instead to set color depends of checkbox state.
- checkbox-checkmark - base color
- checkbox-checked-checkmark - color in case checkbox checked
- checkbox-disabled-checkmark - color in case checkbox disabled and checked
@nnixaa nnixaa added the WIP label Feb 9, 2018
@nnixaa nnixaa closed this as completed in 6b93924 Feb 12, 2018
dimaatkaev added a commit to dimaatkaev/nebular that referenced this issue Feb 13, 2018
@dimaatkaev
feat(checkbox): expand checkbox variables for easier customization
6420f02 
Closes akveo#143
BREAKING CHANGE: Checkbox check mark color variable (radio-fg) is expanded.
There are three variables instead to set a color depending a the checkbox state:
- checkbox-checkmark - base color
- checkbox-checked-checkmark - color when checkbox checked
- checkbox-disabled-checkmark - color when checkbox is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimaatkaev dimaatkaev

Labels
enhancement module:theme WIP
Projects
None yet
Milestone
rc.6
Development

No branches or pull requests
3 participants
@nnixaa @dimaatkaev @tndrm