Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme: Remove cdk mappings duplicates #1544

Closed
1 of 2 tasks
yggg opened this issue May 30, 2019 · 0 comments · Fixed by #2068
Closed
1 of 2 tasks

Theme: Remove cdk mappings duplicates #1544

yggg opened this issue May 30, 2019 · 0 comments · Fixed by #2068
Assignees
@yggg
Labels
bug module:theme P3: minor
Milestone
5.0.0

Comments

@yggg
Copy link
Contributor

yggg commented May 30, 2019

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:
Two NbScrollStrategyOptions.
src/framework/theme/components/cdk/adapter/block-scroll-strategy-adapter.ts and src/framework/theme/components/cdk/overlay/mapping.ts.

Two NbPlatforms.
src/framework/theme/components/cdk/overlay/mapping.ts and src/framework/theme/components/cdk/platform/platform-service.ts.

Expected behavior:
One class for each.

Other information:

Angular, Nebular

@nebular/theme@3-4
@yggg yggg added this to the 4.1.0 milestone May 30, 2019
@yggg yggg changed the title Theme: Remove mappings duplicates Theme: Remove cdk mappings duplicates May 30, 2019
@nnixaa nnixaa modified the milestones: 4.1.0, 4.2.0 Jun 14, 2019
@yggg yggg modified the milestones: 4.2.0, 5.0.0 Jun 27, 2019
@denStrigo denStrigo mentioned this issue Nov 6, 2019
Merged
2 tasks
@yggg yggg closed this as completed in #2068 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yggg yggg

Labels
bug module:theme P3: minor
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

fix(cdk): fix cdk mappings duplicates denStrigo/nebular
2 participants
@nnixaa @yggg