Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): fix cdk mappings duplicates #2068

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

denStrigo
Copy link
Collaborator

@denStrigo denStrigo commented Nov 6, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fix #1544

BREAKING CHANGE:
NbPlatform and NbScrollStrategyOptions from theme/components/cdk/overlay/mapping.ts removed. Use NbPlatform from theme/components/cdk/platform/platform-service.ts and NbScrollStrategyOptions from theme/components/cdk/adapter/block-scroll-strategy-adapter.ts.
NbPlatformModule removed.

@denStrigo denStrigo self-assigned this Nov 6, 2019
@denStrigo denStrigo requested a review from yggg November 6, 2019 17:26
@yggg yggg added this to the 5.0.0 milestone Nov 12, 2019
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #2068 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
- Coverage   84.73%   84.71%   -0.02%     
==========================================
  Files         235      234       -1     
  Lines        8036     8030       -6     
  Branches      707      707              
==========================================
- Hits         6809     6803       -6     
  Misses       1010     1010              
  Partials      217      217
Impacted Files Coverage Δ
.../framework/theme/components/cdk/overlay/mapping.ts 96.29% <ø> (-0.38%) ⬇️
...amework/theme/components/cdk/table/table.module.ts 100% <ø> (ø) ⬆️
...rk/theme/components/cdk/overlay/overlay-service.ts 100% <ø> (ø) ⬆️
...k/theme/components/cdk/overlay/overlay-position.ts 95.72% <100%> (+0.03%) ⬆️
.../theme/components/cdk/platform/platform-service.ts 100% <100%> (ø) ⬆️
...omponents/cdk/adapter/scroll-dispatcher-adapter.ts 100% <100%> (ø) ⬆️
...e/components/cdk/adapter/viewport-ruler-adapter.ts 100% <100%> (ø) ⬆️
src/framework/theme/public_api.ts 100% <100%> (ø) ⬆️

@yggg yggg merged commit 8179a02 into akveo:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme: Remove cdk mappings duplicates
2 participants