Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The object doesn't support this property or method "contains" in NbToastrContainerRegistry #1673

Closed
1 of 2 tasks
gregoryalary opened this issue Jul 2, 2019 · 0 comments · Fixed by #1872
Closed
1 of 2 tasks

The object doesn't support this property or method "contains" in NbToastrContainerRegistry #1673

gregoryalary opened this issue Jul 2, 2019 · 0 comments · Fixed by #1872
Labels
bug module:components P2: important quality

Comments

@gregoryalary
Copy link

Issue type

I'm submitting a bug report

  • bug report
  • feature request

Issue description

Current behavior:
When using the ToastrService on IE11 the error The object doesn't support this property or method "contains" in NbToastrContainerRegistry might happen.

The cause is that :

IE does not regard 'document' as a node and I needed to use 'document.body.contains' to determine items at the end of the row.

as explained in this Stack overflow answer.

Expected behavior:
This bug should not happen.

Steps to reproduce:
I tried to reproduce it but it seems pretty random.
The fact that currently we're calling contains on the document sounds like an error anyways.

Other information:

npm, node, OS, Browser

Browser: IE11

Angular, Nebular

Nebular: 3.5.0
Angular: 7.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug module:components P2: important quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(toastr): call contains on body
2 participants
@yggg @gregoryalary