fix(toastr): call contains on body #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackoverflow.com/questions/38582105/javascript-document-contains-not-working-on-ie11/38733466#38733466 IE does not regard 'document' as a node and calling `contains` on document throws.
Codecov Report
@@ Coverage Diff @@
## master #1872 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 234 234
Lines 7695 7695
Branches 675 675
=======================================
Hits 6466 6466
Misses 1031 1031
Partials 198 198
|
nnixaa
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1673.
stackoverflow.com/questions/38582105/javascript-document-contains-not-working-on-ie11/38733466#38733466
IE does not regard 'document' as a node and calling
containsondocument throws.