Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Partial of Component in NbDialogService open context #1175

Merged
merged 6 commits into from
Feb 18, 2019
Merged

Accept Partial of Component in NbDialogService open context #1175

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5440452
Accept Partial of Component in NbDialogService open context
sasikumardr Jan 22, 2019
6be771d
NBDialogService Open - Accept String or partial of Component in context
sasikumardr Jan 22, 2019
750512f
split line having more than 120 chars to avoid tslint error
sasikumardr Jan 22, 2019
7ebe378
Merge branch 'master' into NbDialogService-context-patch
tibing-old-email Feb 15, 2019
7f61fe8
Merge branch 'master' into NbDialogService-context-patch
tibing-old-email Feb 15, 2019
157e5e8
Merge branch 'master' into NbDialogService-context-patch
nnixaa Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/framework/theme/components/dialog/dialog.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ export class NbDialogService {
/**
* Opens new instance of the dialog, may receive optional config.
* */
open<T>(content: Type<T> | TemplateRef<T>, userConfig: Partial<NbDialogConfig<T>> = {}): NbDialogRef<T> {
open<T>(content: Type<T> | TemplateRef<T>,
userConfig: Partial<NbDialogConfig<Partial<T> | string>> = {}): NbDialogRef<T> {
Tibing marked this conversation as resolved.
Show resolved Hide resolved
const config = new NbDialogConfig({ ...this.globalConfig, ...userConfig });
const overlayRef = this.createOverlay(config);
const dialogRef = new NbDialogRef<T>(overlayRef);
Expand Down