Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): get back default 15px offset #1201

Merged
merged 1 commit into from
Jan 31, 2019
Merged

fix(popover): get back default 15px offset #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ describe('dynamic-overlay-handler', () => {
expect(positionBuilder._connectedTo).toBe(host1);
expect(positionBuilder._position).toBe(NbPosition.TOP);
expect(positionBuilder._adjustment).toBe(NbAdjustment.NOOP);
expect(positionBuilder._offset).toBe(0);
expect(positionBuilder._offset).toBe(15);

configure().host(host2).rebuild();
expect(triggerStrategyBuilder._host).toBe(host2.nativeElement);
Expand All @@ -415,7 +415,7 @@ describe('dynamic-overlay-handler', () => {
expect(positionBuilder._connectedTo).toBe(host2);
expect(positionBuilder._position).toBe(NbPosition.TOP);
expect(positionBuilder._adjustment).toBe(NbAdjustment.NOOP);
expect(positionBuilder._offset).toBe(0);
expect(positionBuilder._offset).toBe(15);
});

it('should set and update position', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class NbDynamicOverlayHandler {
protected _trigger: NbTrigger = NbTrigger.NOOP;
protected _position: NbPosition = NbPosition.TOP;
protected _adjustment: NbAdjustment = NbAdjustment.NOOP;
protected _offset: number = 0;
protected _offset: number = 15;

protected dynamicOverlay: NbDynamicOverlay;

Expand Down
2 changes: 1 addition & 1 deletion src/framework/theme/components/popover/popover.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ import { NbPopoverComponent } from './popover.component';
* If you wanna disable this behaviour just set it falsy value.
*
* ```html
* <button nbPopover="Hello, Popover!" [nbPopoverAdjust]="false"></button>
* <button nbPopover="Hello, Popover!" [nbPopoverAdjustment]="false"></button>
* ```
*
* Popover has a number of triggers which provides an ability to show and hide the component in different ways:
Expand Down