Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons Library, Eva icons #1319

Merged
merged 36 commits into from
Mar 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
72b9633
feat(theme): add NbIcon component (WIP)
nnixaa Mar 5, 2019
a771541
feat(theme): add icon service WIP
nnixaa Mar 5, 2019
e74a474
refactor
nnixaa Mar 19, 2019
47bd485
tests: test icons
nnixaa Mar 19, 2019
4d13be2
on push
nnixaa Mar 20, 2019
1aa14a8
feat: enable nebular-icons by default
nnixaa Mar 20, 2019
ee93e24
refactor: remove eva icons
nnixaa Mar 20, 2019
2e5809a
refactor(actions): use nb-icon instead of i
nnixaa Mar 21, 2019
21c02b9
refactor(theme): remove use of scss functions (#1256)
nnixaa Mar 21, 2019
74654d2
feat(theme): css variables support (#1257)
nnixaa Mar 21, 2019
f840d7a
refactor(chat): use nb-icon instead of span
nnixaa Mar 21, 2019
f05575c
refactor(icons): move services from theme
nnixaa Mar 22, 2019
7cb0191
refactor(menu): use nb-icon instead of span
nnixaa Mar 22, 2019
8ba2f64
refactor(tabs): use nb-icon instead of span
nnixaa Mar 22, 2019
4e8f5cf
refactor(stepper): use nb-icon instead of span
nnixaa Mar 22, 2019
7b8a258
refactor(toastr): use nb-icon instead of span
nnixaa Mar 22, 2019
a4cd78e
refactor(tooltip): use nb-icon instead of span
nnixaa Mar 22, 2019
c85055a
refactor(tree-grid): use nb-icon instead of span
nnixaa Mar 22, 2019
87760f7
refactor(auth): use nb-icon instead of span
nnixaa Mar 22, 2019
90555e7
refactor(theme): default svg pack for built in components
nnixaa Mar 25, 2019
8d99416
feat(playground): register eva and replace icons in examples
nnixaa Mar 25, 2019
b7e97f3
feat(icon): icon color example
nnixaa Mar 25, 2019
3b6eef1
feat(button): add button icon
nnixaa Mar 26, 2019
1b5fbec
feat(icon): add docs
nnixaa Mar 26, 2019
0e78376
feat(icon): add docs
nnixaa Mar 26, 2019
88a2576
refactor(docs): new eva-icons
nnixaa Mar 26, 2019
5c07de2
Merge branch 'master' into feat/3.5-icons
yggg Mar 27, 2019
80e632e
refactor(icons): multiple fixes
nnixaa Mar 27, 2019
b81860c
refactor: remove nebular-icons usage
nnixaa Mar 27, 2019
1be28f2
refactor: replace nebular icons with eva icons in ng-add schematic
nnixaa Mar 27, 2019
64bd644
docs: deprecate nebular-icons note
nnixaa Mar 27, 2019
01ed940
fix: add tests, fix couple of issues
nnixaa Mar 27, 2019
01f2fc0
fix: fix chat icon check and tostr default icon pack
nnixaa Mar 28, 2019
0dbb8f3
Merge branch 'feat/4.0' into feat/3.5-icons
nnixaa Mar 28, 2019
1e1b3cd
Merge branch 'next' into feat/3.5-icons
nnixaa Mar 28, 2019
346c603
fix(docs): typography fix
nnixaa Mar 28, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions DEV_DOCS.md
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,8 @@ To give the user capability switch between live and inline representation of the

# Release

0. For major version, search for `@breaking-change` to make sure all breaking changes are covered.

To start a new release (publish the framework packages on NPM) you need:

1. create a new release branch called `release:v1.0.2`
Expand Down
6 changes: 0 additions & 6 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"src/favicon.ico"
],
"styles": [
"node_modules/nebular-icons/scss/nebular-icons.scss",
"src/styles.scss"
],
"scripts": []
Expand Down Expand Up @@ -77,7 +76,6 @@
"tsConfig": "src/tsconfig.spec.json",
"scripts": [],
"styles": [
"node_modules/nebular-icons/scss/nebular-icons.scss",
"src/styles.scss"
],
"assets": [
Expand Down Expand Up @@ -147,7 +145,6 @@
"src/favicon.ico"
],
"styles": [
"node_modules/nebular-icons/scss/nebular-icons.scss",
"src/styles.scss"
],
"scripts": []
Expand Down Expand Up @@ -198,7 +195,6 @@
"tsConfig": "src/tsconfig.spec.json",
"scripts": [],
"styles": [
"node_modules/nebular-icons/scss/nebular-icons.scss",
"src/styles.scss"
],
"assets": [
Expand Down Expand Up @@ -266,7 +262,6 @@
"node_modules/bootstrap/dist/css/bootstrap.css",
"node_modules/docsearch.js/dist/cdn/docsearch.min.css",
"node_modules/highlight.js/styles/dracula.css",
"node_modules/nebular-icons/scss/nebular-icons.scss",
"docs/app/@theme/styles/styles.scss"
],
"scripts": [
Expand Down Expand Up @@ -321,7 +316,6 @@
],
"styles": [
"node_modules/highlight.js/styles/dracula.css",
"node_modules/nebular-icons/scss/nebular-icons.scss",
"docs/app/@theme/styles/styles.scss"
],
"assets": [
Expand Down
4 changes: 3 additions & 1 deletion docs/app/@theme/components/header/header.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
flex: 1 0 auto;
padding: 0 0.5rem;

.nb-menu {
nb-icon {
vertical-align: middle;
font-size: 1.75rem;
color: $version-fg;
}
}

Expand Down
2 changes: 1 addition & 1 deletion docs/app/@theme/components/header/header.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { NgdVersionService } from '../../services';
template: `
<div class="section left">
<button *ngIf="sidebarTag" class="sidebar-toggle" (click)="toggleSidebar()">
<i class="nb-menu"></i>
<nb-icon icon="menu-2"></nb-icon>
</button>
<div class="logo">
<a routerLink="/">Nebular</a>
Expand Down
31 changes: 14 additions & 17 deletions docs/app/@theme/components/page-tabs/page-tabs.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,15 @@
font-weight: 500;
}

.icon {
font-size: 1.5rem;
padding-bottom: 1rem;
.text-container {
display: flex;
flex-direction: column;
align-items: center;
}

::ng-deep nb-icon {
nnixaa marked this conversation as resolved.
Show resolved Hide resolved
font-size: 1.875rem;
margin-bottom: 1rem;
}

&.selected {
Expand All @@ -46,12 +52,6 @@
}
}
}

.icon,
.title {
display: block;
text-align: center;
}
}

:host(.horizontal) {
Expand All @@ -62,19 +62,15 @@
padding: 0 1rem;

.title,
.icon {
display: inline;
padding-bottom: 0;
vertical-align: middle;
}

.icon {
::ng-deep nb-icon {
margin-bottom: 1rem;
margin-right: 0.5rem;
}
}

.text-container {
padding-bottom: 1.3rem;
flex-direction: row;
padding-bottom: 0;
}

.line {
Expand All @@ -87,6 +83,7 @@

a {
flex: 1 1 0;
margin-bottom: 0;

&.selected::after {
content: '';
Expand Down
10 changes: 5 additions & 5 deletions docs/app/@theme/components/page-tabs/page-tabs.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { Observable, of as observableOf, combineLatest } from 'rxjs';
template: `
<a *ngFor="let item of items$ | async" [class.selected]="item.selected" [routerLink]="['../', item.tab]">
<div class="text-container">
<i class="icon {{ item.icon }}"></i>
<nb-icon [icon]="item.icon"></nb-icon>
<span class="title">{{ item.title }}</span>
</div>
<i class="line"></i>
Expand Down Expand Up @@ -57,23 +57,23 @@ export class NgdPageTabsComponent implements OnDestroy {
{
tab: 'overview',
title: 'Overview',
icon: 'feather-eye',
icon: 'eye-outline',
selected: true,
},
{
tab: 'api',
title: 'API',
icon: 'feather-settings',
icon: 'settings-outline',
},
{
tab: 'theme',
title: 'Theme',
icon: 'feather-droplet',
icon: 'droplet-outline',
},
{
tab: 'examples',
title: 'Examples',
icon: 'feather-image',
icon: 'image-outline',
},
];
private alive = true;
Expand Down
2 changes: 1 addition & 1 deletion docs/app/@theme/components/search/search.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}
}

.icon {
nb-icon {
color: $fg;
position: absolute;
top: 50%;
Expand Down
2 changes: 1 addition & 1 deletion docs/app/@theme/components/search/search.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { NB_WINDOW } from '@nebular/theme';
selector: 'ngd-search',
styleUrls: ['./search.component.scss'],
template: `
<i class="icon feather-search"></i>
<nb-icon icon="search-outline"></nb-icon>
<input type="text" id="doc-search" placeholder="Start typing...">
`,
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down
2 changes: 1 addition & 1 deletion docs/app/@theme/styles/styles.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@import 'themes';
@import 'common';
@import 'small-social';
@import 'feather';

@import '../../../../src/framework/theme/styles/global/normalize';
@import '../../../../src/framework/theme/styles/global/components';
Expand All @@ -16,6 +15,7 @@
@include nb-actions-theme();
@include nb-search-theme();
@include nb-bootstrap-global();
@include nb-icon-theme();

@include nb-typography();

Expand Down
6 changes: 6 additions & 0 deletions docs/app/@theme/theme.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ import {
NbSidebarModule,
NbCardModule,
NbCheckboxModule,
NbIconModule,
} from '@nebular/theme';

import { NbEvaIconsModule } from '@nebular/eva-icons';

import {
NgdHeaderComponent,
NgdHeroComponent,
Expand Down Expand Up @@ -57,6 +60,8 @@ import {
NbCardModule,
NbMenuModule,
NbTabsetModule,
NbIconModule,
NbEvaIconsModule,
RouterModule,
],
declarations: [
Expand All @@ -77,6 +82,7 @@ import {
RouterModule,
ReactiveFormsModule,
FormsModule,
NbIconModule,
NbLayoutModule,
NbSidebarModule,
NbCardModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@
<select class="action-item" [(ngModel)]="currentTheme" (change)="switchTheme($event.target.value)">
<option *ngFor="let theme of themes" [value]="theme.value">{{theme.label}}</option>
</select>
<i class="icon feather-aperture"></i>
<nb-icon icon="color-palette-outline"></nb-icon>
</div>
<a class="btn action-item action-button" target="_blank" [href]="url">
<i class="icon feather-external-link"></i>
<nb-icon icon="external-link-outline"></nb-icon>
</a>
<button type="button"
*ngIf="hasViewSwitch"
class="btn action-item action-button"
(click)="switchToInlineVew()">
<i class="icon feather-code"></i>
<nb-icon icon="code-outline"></nb-icon>
</button>
</div>
</section>
<div class="iframe-container">
<iframe #iframe *ngIf="content.id" [style.height.px]="iframeHeight" [class.loading]="loading"></iframe>
</div>
<span class="icon-loading feather-more-vertical" *ngIf="loading"></span>
<nb-icon class="icon-loading" icon="more-vertical-outline" *ngIf="loading"></nb-icon>
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
display: flex;
width: 100%;

.icon {
nb-icon {
font-size: 0.95rem;
}
}
Expand Down Expand Up @@ -73,7 +73,7 @@
color: transparent;
}

.icon {
nb-icon {
color: $action-fg;
position: absolute;
top: 50%;
Expand Down Expand Up @@ -156,7 +156,7 @@
padding: 0 2.5rem;
}

.icon {
nb-icon {
left: 1.25rem;
transform: translate(0, -50%);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
font-weight: 500;
font-size: 1.2rem;

i {
nb-icon {
color: $arrow-fg;
margin-top: 0.3rem;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { NgdPaginationService } from '../../../@theme/services';
<a *ngIf="paginationItem.prev" [routerLink]="paginationItem.prev.link"
[attr.title]="paginationItem.prev.title">
<div class="page-title">
<i class="icon feather-arrow-left"></i>
<nb-icon icon="arrow-back-outline"></nb-icon>
<span>{{ paginationItem.prev.title }}</span>
</div>
<div class="description">Previous page</div>
Expand All @@ -23,7 +23,7 @@ import { NgdPaginationService } from '../../../@theme/services';
[attr.title]="paginationItem.next.title">
<div class="page-title">
<span>{{ paginationItem.next.title }}</span>
<i class="icon feather-arrow-right"></i>
<nb-icon icon="arrow-forward-outline"></nb-icon>
</div>
<div class="description">Next page</div>
</a>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*ngIf="hasViewSwitch"
class="btn action-item action-button"
(click)="switchToLiveView()">
<i class="icon feather-image"></i>
<nb-icon icon="image-outline"></nb-icon>
<span class="text">Live view</span>
</button>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
font-weight: normal;
font-size: 0.9rem;

.icon {
font-size: 0.95rem;
nb-icon {
font-size: 1rem;
vertical-align: middle;
}

&:focus, &:active, &:hover {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ <h2>{{ vm.themeTitle }} Theme</h2>
<a [routerLink]="['/docs/themes', parent.theme]" fragment="{{ parent.prop }}"
[class.inheritance-property]="index > 0"
*ngFor="let parent of prop.parents; let index = index">
<i *ngIf="index > 0" class="inheritance-icon feather-arrow-left"></i>
<nb-icon *ngIf="index > 0" class="inheritance-icon" icon="arrow-back-outline"></nb-icon>
<span>{{ parent.prop }}</span>
<span *ngIf="parent.theme !== vm.themeName" class="parent-theme-name">({{ parent.theme }})</span>
</a>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
$selected-row-bg: nb-theme(color-gray-light);

.inheritance-icon {
font-size: 1rem;
margin: 0 0.25rem;
vertical-align: middle;
}

.inheritance-property {
Expand Down
4 changes: 4 additions & 0 deletions docs/app/documentation/documentation.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@
}
}

nb-icon {
display: none;
}

.menu-items .menu-item .menu-item a {
&:hover, &.active, &:focus {
text-shadow: 0.5px 0 0 currentColor;
Expand Down
2 changes: 1 addition & 1 deletion docs/app/example/example-404.component.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
::ng-deep nb-layout-column {
:host {
align-items: center;
display: flex;
color: gray;
Expand Down
4 changes: 1 addition & 3 deletions docs/app/example/example-404.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ import { NbThemeService } from '@nebular/theme';
@Component({
selector: 'ngd-example-404',
template: `
<nb-layout>
<nb-layout-column>Example not found.</nb-layout-column>
</nb-layout>
Example not found.
`,
styleUrls: ['./example-404.component.scss'],
})
Expand Down
Loading