fix(option): emit selection change when selection is changed #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously NbOptionComponent 'selectionChange' where emitted only when option clicked, ignoring cases where select/deselect methods were called from NbSelectComponent. Also deprecates NbSelectComponent 'selectionChange' property. We already has 'selectedChange' for this. Also 'selectionChange' name is a bit confusing since it emits only when option clicked.
Flush microtask registered in ngAfterViewInit of select component. Then call detect changes in case option were selected.
Also moves test related to select into select describe
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
+ Coverage 81.14% 81.17% +0.03%
==========================================
Files 232 232
Lines 7048 7049 +1
Branches 598 598
==========================================
+ Hits 5719 5722 +3
+ Misses 1152 1151 -1
+ Partials 177 176 -1
|
yggg
commented
Apr 8, 2019
nnixaa
reviewed
Apr 8, 2019
| /** | ||
| * Stream of events that will fire when one of the options fire selectionChange event. | ||
| * */ | ||
| /* @deprecated */ | ||
| protected selectionChange$: Subject<NbOptionComponent<T>> = new Subject(); |
There was a problem hiding this comment.
since this is internal change there is no need to deprecate it, we can just break it
| @@ -115,10 +122,10 @@ export class NbOptionComponent<T> implements OnDestroy { | |||
| * Also Angular can call writeValue on destroyed view (select implements ControlValueAccessor). | |||
| * angular/angular#27803 | |||
| * */ | |||
| if (this.alive) { | |||
| if (this.alive && this.selected !== isSelected) { | |||
There was a problem hiding this comment.
since instance variable is called selected why don't we call local variable same selected?
nnixaa
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Previously NbOptionComponent 'selectionChange' where emitted only when
option clicked, ignoring cases where select/deselect methods were called
from NbSelectComponent.
Also deprecates NbSelectComponent 'selectionChange' property.
We already has 'selectedChange' for this. Also 'selectionChange' name is
a bit confusing since it emits only when option clicked.