-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio): Eva style #1344
Merged
Merged
feat(radio): Eva style #1344
Changes from 19 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
544237a
feat(radio): eva styles
yggg 267670b
refactor(radio): align class names with checkbox
yggg b07dbe9
fix(radio): update and resubscribe to option after they change
yggg 3138b24
fix(radio): update and resubscribe to option after they change
yggg 3dd3cd7
feat(radio): add statuses to radio button
yggg 00a4ce2
refactor(radio): style using updated component properties
yggg 409b149
fix(radio): prevent inner circle distortion
yggg 37a550a
docs(radio): add statuses and disabled group examples
yggg 79931f2
docs(radio): update theme properties list
yggg fc04ebf
fix(radio): proper typography settings
yggg 0eb812f
refactor(radio): remove white status
yggg 89df6bd
feat(radio): add background color
yggg 5476810
refactor(radio): remove named inputs
yggg 7496c65
refactor(radio): remove own status enum and use shared
yggg f725667
fix(radio): typo
yggg 1458ec0
docs(radio): fix examples
yggg 94d2f2b
feat(radio): add border style theme property
yggg 218f14e
refactor(radio): use named state colors
yggg 60e60c6
feat(radio): prevent setting empty status
yggg c0abb37
docs(radio): update theme properties list
yggg d09570e
refactor(radio): move status class to the host
yggg 42baf59
feat(radio): set default status if value not passed
yggg 09b5f3a
fix(radio): update radio status and trigger change detection
yggg 19e5fe7
refactor(radio): set provided status if it differ from current
yggg b43cc88
refactor(radio): call change detector methods from radio component
yggg 32003be
fix(radio): set radio name right away
yggg 54852e9
Merge branch 'next' into feat/eva-radio
yggg 3275354
fix(radio): prevent subscription creating if no options
yggg 5c2b1d7
feat(radio): initialize radio properties
yggg bae04b9
fix(radio): wait change detection to finish before updating options
yggg 8533560
docs(radio): remove unnecessary interface
yggg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need the same empty check as for checkbox?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need,
nb-get-status
has no empty statuses only'primary'
,'success'
,'warning'
,'danger'
,'info'
.