test(select): flush pending microtasks from other components #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is two task pending. One from button setTimeout and another from spinner service.
…crotasks-it-was-not-an-issue-for-some-reason-but-now-it-is-yes-i-added-set-timeout-in-button-but-spinner-service-load-all-last-changed-in-2017-whyyyyyy
nnixaa
approved these changes
Apr 18, 2019
yggg
deleted the
fix/select-tests-flush-button-and-spinner-microtasks-it-was-not-an-issue-for-some-reason-but-now-it-is-yes-i-added-set-timeout-in-button-but-spinner-service-load-all-last-changed-in-2017-whyyyyyy
branch
yggg
restored the
fix/select-tests-flush-button-and-spinner-microtasks-it-was-not-an-issue-for-some-reason-but-now-it-is-yes-i-added-set-timeout-in-button-but-spinner-service-load-all-last-changed-in-2017-whyyyyyy
branch
yggg
added a commit
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is two task pending. One from button setTimeout and another from
spinner service.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
There is two task pending. One from button setTimeout and another from
spinner service (I have no idea why spinner micro task showed up. It's code here since 2017).