Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actions): Eva style #1397

Merged
merged 15 commits into from
Apr 22, 2019
Merged

feat(actions): Eva style #1397

merged 15 commits into from
Apr 22, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 18, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

NbActionsComponent 'inverseValue' field and 'inverse' setter removed.
NbActionsComponent 'fullWidthValue' field replaced with 'fullWidth'.
NbActionsComponent size class named renamed to 'size-[size-name]'.
NbActionsComponent static fields SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE removed.
NbActionComponent 'disabledValue' field replaced with 'disabled'.

Following theme variables name were renamed:
actions-font-size -> actions-[size]-text-font-size
actions-font-family -> actions-text-font-family
actions-line-height -> actions-text-line-height
actions-fg -> actions-text-color
actions-bg -> actions-background-color
actions-separator -> actions-divider-color
actions-padding -> actions-[size]-padding
actions-size-small -> actions-small-height
actions-size-medium -> actions-medium-height
actions-size-large -> actions-large-height

yggg added 9 commits April 18, 2019 21:53
BREAKING CHANGE:

NbActionsComponent 'inverseValue' field and 'inverse' setter removed
BREAKING CHANGE:

NbActionComponent 'disabledValue' field replaced with 'disabled'.
NbActionsComponent 'fullWidthValue' field replaced with 'fullWidth'.
BREAKING CHANGE:

NbActionsComponent size class named renamed to 'size-[size-name]'.
NbActionsComponent static fields SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE
removed.
BREAKING CHANGE:

Following theme variables name were renamed:
actions-font-size -> actions-[size]-text-font-size
actions-font-family -> actions-text-font-family
actions-line-height -> actions-text-line-height
actions-fg -> actions-text-color
actions-bg -> actions-background-color
actions-separator -> actions-divider-color
actions-padding -> actions-[size]-padding
actions-size-small -> actions-small-height
actions-size-medium -> actions-medium-height
actions-size-large -> actions-large-height
@yggg yggg requested a review from nnixaa April 18, 2019 20:36
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #1397 into next will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##            next    #1397      +/-   ##
=========================================
+ Coverage   82.6%   82.77%   +0.16%     
=========================================
  Files        237      237              
  Lines       7277     7279       +2     
  Branches     637      637              
=========================================
+ Hits        6011     6025      +14     
+ Misses      1079     1067      -12     
  Partials     187      187
Impacted Files Coverage Δ
...work/theme/components/actions/actions.component.ts 100% <100%> (+21.21%) ⬆️
...ramework/theme/components/badge/badge.component.ts 93.54% <0%> (+16.12%) ⬆️

Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Let's use hint color for the icons and disabled for the disabled one.

@yggg
Copy link
Contributor Author

yggg commented Apr 21, 2019

image

Let's use hint color for the icons and disabled for the disabled one.

Fixed. Disabled, icon color.

@yggg yggg requested a review from nnixaa April 21, 2019 15:32
@yggg yggg merged commit c4f1760 into akveo:next Apr 22, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

NbActionsComponent 'inverseValue' field and 'inverse' setter removed.
NbActionsComponent 'fullWidthValue' field replaced with 'fullWidth'.
NbActionsComponent size class named renamed to 'size-[size-name]'.
NbActionsComponent static fields SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE removed.
NbActionComponent 'disabledValue' field replaced with 'disabled'.

Following theme variables name were renamed:
actions-font-size -> actions-[size]-text-font-size
actions-font-family -> actions-text-font-family
actions-line-height -> actions-text-line-height
actions-fg -> actions-text-color
actions-bg -> actions-background-color
actions-separator -> actions-divider-color
actions-padding -> actions-[size]-padding
actions-size-small -> actions-small-height
actions-size-medium -> actions-medium-height
actions-size-large -> actions-large-height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants