-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(actions): Eva style #1397
Merged
Merged
feat(actions): Eva style #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: NbActionsComponent 'inverseValue' field and 'inverse' setter removed
BREAKING CHANGE: NbActionComponent 'disabledValue' field replaced with 'disabled'. NbActionsComponent 'fullWidthValue' field replaced with 'fullWidth'.
BREAKING CHANGE: NbActionsComponent size class named renamed to 'size-[size-name]'. NbActionsComponent static fields SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE removed.
BREAKING CHANGE: Following theme variables name were renamed: actions-font-size -> actions-[size]-text-font-size actions-font-family -> actions-text-font-family actions-line-height -> actions-text-line-height actions-fg -> actions-text-color actions-bg -> actions-background-color actions-separator -> actions-divider-color actions-padding -> actions-[size]-padding actions-size-small -> actions-small-height actions-size-medium -> actions-medium-height actions-size-large -> actions-large-height
Codecov Report
@@ Coverage Diff @@
## next #1397 +/- ##
=========================================
+ Coverage 82.6% 82.77% +0.16%
=========================================
Files 237 237
Lines 7277 7279 +2
Branches 637 637
=========================================
+ Hits 6011 6025 +14
+ Misses 1079 1067 -12
Partials 187 187
|
nnixaa
requested changes
Apr 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Disabled, icon color. |
nnixaa
approved these changes
Apr 22, 2019
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: NbActionsComponent 'inverseValue' field and 'inverse' setter removed. NbActionsComponent 'fullWidthValue' field replaced with 'fullWidth'. NbActionsComponent size class named renamed to 'size-[size-name]'. NbActionsComponent static fields SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE removed. NbActionComponent 'disabledValue' field replaced with 'disabled'. Following theme variables name were renamed: actions-font-size -> actions-[size]-text-font-size actions-font-family -> actions-text-font-family actions-line-height -> actions-text-line-height actions-fg -> actions-text-color actions-bg -> actions-background-color actions-separator -> actions-divider-color actions-padding -> actions-[size]-padding actions-size-small -> actions-small-height actions-size-medium -> actions-medium-height actions-size-large -> actions-large-height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
NbActionsComponent 'inverseValue' field and 'inverse' setter removed.
NbActionsComponent 'fullWidthValue' field replaced with 'fullWidth'.
NbActionsComponent size class named renamed to 'size-[size-name]'.
NbActionsComponent static fields SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE removed.
NbActionComponent 'disabledValue' field replaced with 'disabled'.
Following theme variables name were renamed:
actions-font-size -> actions-[size]-text-font-size
actions-font-family -> actions-text-font-family
actions-line-height -> actions-text-line-height
actions-fg -> actions-text-color
actions-bg -> actions-background-color
actions-separator -> actions-divider-color
actions-padding -> actions-[size]-padding
actions-size-small -> actions-small-height
actions-size-medium -> actions-medium-height
actions-size-large -> actions-large-height