Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flip card): add prefixed backface-visibility property #1658

Merged
merged 3 commits into from
Jul 1, 2019
Merged

fix(flip card): add prefixed backface-visibility property #1658

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8154fa1
fix(flip card): add prefixed backface-visibility property
yggg Jun 29, 2019
008f809
refactor: extract repeated lines into mixin
yggg Jul 1, 2019
d668bbb
Merge branch 'master' into fix/flip-card-safari-back-card-visible
yggg Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/framework/theme/components/card/flip-card/flip-card.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
opacity: 0;
transition: opacity 0s 0.25s;
backface-visibility: hidden;
// Don't remove prefixed property as it's wouldn't be added during the build.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think it would be better to use some kind of mixin instead of copy-pasting the same code + comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do 🙂
Fixed in 008f809

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

// Fixes back card visibility in Safari.
-webkit-backface-visibility: hidden;

.flip-button {
opacity: 0;
Expand All @@ -27,6 +30,9 @@

.back-container {
backface-visibility: visible;
// Don't remove prefixed property as it's wouldn't be added during the build.
// Fixes back card visibility in Safari.
-webkit-backface-visibility: visible;
}
}
}
Expand All @@ -52,11 +58,17 @@

.front-container {
backface-visibility: visible;
// Don't remove prefixed property as it's wouldn't be added during the build.
// Fixes back card visibility in Safari.
-webkit-backface-visibility: visible;
transition: opacity 0s 0.2s;
}

.back-container {
backface-visibility: hidden;
// Don't remove prefixed property as it's wouldn't be added during the build.
// Fixes back card visibility in Safari.
-webkit-backface-visibility: hidden;
transform: rotateY(180deg);
}
}