Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabset): wrap lazy load content into template #1896

Closed
wants to merge 1 commit into from
Closed

fix(tabset): wrap lazy load content into template #1896

wants to merge 1 commit into from

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 9, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

TODO:

  • update docs examples and text
  • add/update tests on lazy loading
  • probably we need to cache lazy content once it's initialized
  • refactoring:
    • extract components into separate files
    • remove <input-name>Value public properties

BREAKING CHANGE:
Following NbTabComponent properties were removed:

  • init - use active instead
  • lazyLoad - instead wrap lazy content into nb-template with nbTabLazyContent directive.

Closes #1827, closes #1587.

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #1896 into master will decrease coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #1896      +/-   ##
==========================================
- Coverage   83.88%   83.88%   -0.01%     
==========================================
  Files         232      232              
  Lines        7595     7594       -1     
  Branches      670      669       -1     
==========================================
- Hits         6371     6370       -1     
  Misses       1027     1027              
  Partials      197      197
Impacted Files Coverage Δ
...framework/theme/components/tabset/tabset.module.ts 100% <100%> (ø) ⬆️
...mework/theme/components/tabset/tabset.component.ts 91.83% <75%> (-0.17%) ⬇️

@yggg yggg requested a review from nnixaa October 8, 2019 16:22
@dmk1111
Copy link

dmk1111 commented Dec 11, 2020

@yggg any updates on this?

@yggg yggg closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix lazy loading in Tab component Looking for doc 2.0.0-rc.6
2 participants