Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): change @HostListener accessor modifier #2240

Closed
wants to merge 1 commit into from

Conversation

rjlopezdev
Copy link
Contributor

@rjlopezdev rjlopezdev commented Feb 27, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

New nb-autocomplete component causes a build compilation error on production mode (AOT) cause of NbAutocompleteDirectivedoesn't expose @HostListener's & is used from outside class.

Code below

<input
  [formControl]="inputFormControl"
  nbInput
  type="text"
  placeholder="Form control"
  [nbAutocomplete]="autoControl" />

 <nb-autocomplete #autoControl>

  <nb-option *ngFor="let option of filteredControlOptions$ | async" [value]="option">
    {{ option }}
  </nb-option>

</nb-autocomplete>

causes the following errors:

ERROR in ...: Directive NbAutocompleteDirective, Property 'handleInput' is protected and only accessible within class 'NbAutocompleteDirective<T>' and its subclasses.
...: Directive NbAutocompleteDirective, Property 'handleKeydown' is protected and only accessible within class 'NbAutocompleteDirective<T>' and its subclasses.
...: Directive NbAutocompleteDirective, Property 'handleKeydown' is protected and only accessible within class 'NbAutocompleteDirective<T>' and its subclasses.
...: Directive NbAutocompleteDirective, Property 'handleBlur' is protected and only accessible within class 'NbAutocompleteDirective<T>' and its subclasses.

New `nb-autocomplete` component causes a build compilation error on production mode (AOT) cause of `NbAutocompleteDirective`doesn't expose `@HostListener`'s & is used from outside class.
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #2240 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2240      +/-   ##
==========================================
- Coverage   84.45%   84.41%   -0.04%     
==========================================
  Files         248      248              
  Lines        8605     8605              
  Branches      772      772              
==========================================
- Hits         7267     7264       -3     
- Misses       1111     1114       +3     
  Partials      227      227              
Impacted Files Coverage Δ
.../framework/theme/components/menu/menu.component.ts 77.86% <0.00%> (-1.64%) ⬇️
...rc/framework/theme/components/menu/menu.service.ts 87.32% <0.00%> (-0.71%) ⬇️

@yggg yggg added this to the 5.0.0 milestone Mar 3, 2020
@yggg
Copy link
Contributor

yggg commented Mar 13, 2020

@rjlopezdev Thanks! I picked your changes in the #2273, so closing this one

@yggg yggg closed this Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants