Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nbButton): allow specifying custom tabindex #2452

Merged
merged 2 commits into from
Jul 29, 2020
Merged

fix(nbButton): allow specifying custom tabindex #2452

merged 2 commits into from
Jul 29, 2020

Conversation

maksim-karatkevich
Copy link
Contributor

@maksim-karatkevich maksim-karatkevich commented Jul 17, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2407

@maksim-karatkevich maksim-karatkevich requested a review from yggg July 17, 2020 12:51
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #2452 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
+ Coverage   81.50%   81.52%   +0.01%     
==========================================
  Files         244      244              
  Lines        7382     7387       +5     
  Branches      774      775       +1     
==========================================
+ Hits         6017     6022       +5     
+ Misses       1136     1134       -2     
- Partials      229      231       +2     
Impacted Files Coverage Δ
...mework/theme/components/button/button.component.ts 84.44% <33.33%> (-2.62%) ⬇️
...ramework/theme/components/toastr/toastr.service.ts 97.39% <0.00%> (+2.60%) ⬆️

@yggg yggg changed the title fix(tabIndex): fix tab index value assigment fix(nbButton): allow specifying custom tabindex Jul 29, 2020
@yggg yggg merged commit e9f84be into master Jul 29, 2020
@yggg yggg deleted the fix/tabIndex branch July 29, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change TabIndex Values on nbButton
2 participants