Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add support for refresh tokens #390

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

dizco
Copy link
Contributor

@dizco dizco commented Apr 25, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Added a way to refresh tokens inside the AuthService. This is not yet hooked anywhere, but it could be hooked inside an interceptor, as I've seen mentionned in #260. Typically, I think the refresh token would be stored in a HttpOnly cookie. This also addresses #362.

this.authService.refreshToken('email').subscribe((result: NbAuthResult) => {
  //Do something
});

I have also fixed #389, which involved changing private getProvider to protected getProvider.

Please let me know if I need to change anything!

@dizco dizco force-pushed the dizco-fix-get-provider branch from 5ca9245 to 75162d1 Compare April 25, 2018 03:56
@nnixaa
Copy link
Collaborator

nnixaa commented Apr 25, 2018

Hey @dizco, looks great to me! Very good addition. @Tibing what do you think?

@nnixaa nnixaa merged commit dc57c85 into akveo:master Apr 26, 2018
@nnixaa
Copy link
Collaborator

nnixaa commented Apr 26, 2018

Thanks again, @dizco. If by any chance you have other ideas we would be happy to discuss 😃

@dizco
Copy link
Contributor Author

dizco commented Apr 26, 2018

@nnixaa no problem! I'll let you guys know if I think of anything else 😃 I guess the best way moving forward would be to open issues right?

@dizco dizco deleted the dizco-fix-get-provider branch April 26, 2018 14:03
@nnixaa
Copy link
Collaborator

nnixaa commented Apr 26, 2018

@dizco yes, exactly. Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthService getProvider() should be protected instead of private
2 participants